Port Deluminate to Firefox

[Galexlol]

I've tried others and they are completely useless compared to Deluminate, eyes hurt and they don't work for half the pages, especially Dark Reader

We REALLY need this on Firefox as this is pretty much the only reason i haven't switched yet and the extension to import doesn't work

[abstiles]

I think you're right. For now, my priority is updating Deluminate to support Manifest v3, but next on my agenda is looking into what Firefox support entails.

[abstiles]

Checked the current state of the dev branch with their validator.

Biggest issue I see right now is that Firefox does not seem to support the background service worker feature for Manifest V3. That may require some reworking. Other issues seem easy enough to handle:

• Add a unique extension ID.
• Drop the offscreen page, which is only needed for migrating from the older localStorage for settings.
• Set a minimum Firefox version that supports the Manifest V3 features I use.
• Validate that everything renders correctly. (On mobile too, probably? Might have to tweak the popup.)
• chrome => browser for the browser APIs, I assume? Maybe they just alias chrome for ease of migration, though.

[abstiles]

I did a quick, hacky set of modifications to test on Firefox, and I've got something mostly working, at least. There were a few rendering errors with the popup that needed fixing, but the obvious remaining issues I noticed from a cursory test are:

• Animated GIF detection is totally broken.
• The popup doesn't automatically close when clicking the settings or bug report links.
• Extension activates on (at least some)moz-extension:// pages that it doesn't on the equivalent chrome://

The GIF thing is probably related to the background service worker. I may need to maintain two different implementations until/unless they eventually resolve bug 1573659. That's been open for five years now, though, so I won't be holding my breath.

[Galexlol]

I think you're right. For now, my priority is updating Deluminate to support Manifest v3, but next on my agenda is looking into what Firefox support entails.

you're awesome ab

don't wanna spam here :D

[Genhis]

I also want to voice my support for Firefox. I am migrating off Chrome because uBO stopped working and I've got used to Deluminate so much that it's going to be difficult to find a good replacement.

[FredrIQ]

Yeah, I'm also looking forward to being able to use this on Firefox, it's the only reason I kept using Chrome for years. I'm on UltimaDark at the moment, but it took me mere minutes before I started encountering problems that I have never had with Deluminate...