deluminate icon indicating copy to clipboard operation
deluminate copied to clipboard

Updated Chrome. Deluminate no longer inverting.

Open rievealavaix opened this issue 6 years ago • 13 comments

What version of Chrome are you using?

Version 65.0.3325.146 (Official Build) (64-bit)

What version of Deluminate do you have installed?

0.7.6

What Operating System are you using?

Windows 10 Home

What is the problem?

Pages will no longer invert

Can you link to a web page that has the problem?

facebook.com https://www.huffingtonpost.com/2012/07/31/olek-yarn-bombs-albert-ei_n_1720867.html https://www.designboom.com/art/olek-crocheted-charging-bull/

every page i've gone to so far

Which Deluminate modes have the problem?

All Invert Luminance modes

rievealavaix avatar Mar 08 '18 01:03 rievealavaix

Same as https://github.com/abstiles/deluminate/issues/591 Happens to me too.

Version 65.0.3325.146 (Official Build) (64-bit)
Ubuntu 17.10
0.7.6

fenollp avatar Mar 08 '18 09:03 fenollp

Same here, using High Contrast plugin for now and it works: https://chrome.google.com/webstore/detail/high-contrast/djcfdncoelnlbldjfhinnjlhdjlikmph/related?utm_source=chrome-app-launcher-info-dialog

So something changed in the Chrome API that only affects Deluminate.

andreas-bergstrom avatar Mar 08 '18 10:03 andreas-bergstrom

Same here

RononDex avatar Mar 08 '18 15:03 RononDex

So something changed in the Chrome API that only affects Deluminate.

Not sure the Chrome API is the culprit. I am maintaining a website for one of the OS project which internally employs the same CSS filtering technique used by this plugin and continue to work till now. Still, I am here because all my other favorite websites are not inverted as per before and they are hurting my eyes.

weitjong avatar Mar 10 '18 04:03 weitjong

Chrome API or not, this is an annoying one. Would love to see this fixed somehow.

V13Axel avatar Mar 12 '18 16:03 V13Axel

Looks like this has already been fixed in the dev branch: https://chrome.google.com/webstore/detail/deluminate-dev/kjnhbpoabhlpigfobifmnfmeekamjpmo/related

Dunno when that'll get merged into master... but I've confirmed it working.

V13Axel avatar Mar 13 '18 13:03 V13Axel

Can confirm that @V13Axel's link to the dev version solves this issue on Version 65.0.3325.146 (Official Build) (64-bit) on latest ubuntu.

cc https://github.com/abstiles/deluminate/issues/588 https://github.com/abstiles/deluminate/issues/589 https://github.com/abstiles/deluminate/issues/591 https://github.com/abstiles/deluminate/issues/592 https://github.com/abstiles/deluminate/issues/593 https://github.com/abstiles/deluminate/issues/594 https://github.com/abstiles/deluminate/issues/595 https://github.com/abstiles/deluminate/issues/596 https://github.com/abstiles/deluminate/issues/597 https://github.com/abstiles/deluminate/issues/598 https://github.com/abstiles/deluminate/issues/599 https://github.com/abstiles/deluminate/issues/600 https://github.com/abstiles/deluminate/issues/601 https://github.com/abstiles/deluminate/issues/602 Please search for your issue first on the issues page people. I wish https://github.com/sindresorhus/refined-github/issues/1138 was a thing!

PS @abstiles I'm okay triaging issues if you need some help you can add me to the contributors ;)

fenollp avatar Mar 13 '18 16:03 fenollp

@fenollp Perhaps an idea would be to change the link "Something Wrong?" to point to the issue page first (in reading mode), and then have people from there create a new issue if they don't find it. I accidentally created yet another duplicate by just following the form.

LaurentPointCa avatar Mar 15 '18 19:03 LaurentPointCa

That or encourage github to automatically search for similar issues when creating new ones. In both cases I don't have commit rights :)

fenollp avatar Mar 16 '18 00:03 fenollp

I suggest you change the "Something wrong? Let me know!" link to the main issues page, if it sends to a new issue as it currently does people will report it before checking if it's been reported.

Just closed my own issue because I'll be damned if I'm a duplicated issue generator.

Big fan of Deluminate btw, thanks for working on this :)

PedroGFonseca avatar Mar 22 '18 16:03 PedroGFonseca

Mine is working now.

futurechan avatar Mar 23 '18 13:03 futurechan

Version 66.0.3359.26 (Official Build) dev (64-bit) (Chrome Unstable) on Ubuntu 16.04 is confirmed working again. Thank goodness, my eyes are saved once again.

dluther avatar Mar 24 '18 17:03 dluther

Same for Chrome stable on Ubuntu 17.10 Version 65.0.3325.181 (Official Build) (64-bit). Now I can use all my preferences again!

fenollp avatar Mar 30 '18 09:03 fenollp