nsq icon indicating copy to clipboard operation
nsq copied to clipboard

async rpc in put message to cluster

Open DoraALin opened this issue 8 years ago • 5 comments

Signed-off-by: 元守 [email protected] change rpc call in async way in PutMessageToCluster & PutMessagesToCluster async in put messages to cluster

DoraALin avatar May 09 '17 03:05 DoraALin

@absolute8511 for your review again.

DoraALin avatar May 15 '17 10:05 DoraALin

@absolute8511 for your review

DoraALin avatar May 16 '17 03:05 DoraALin

@absolute8511 for your review. async rpc response wait incorporated in SlaveWriteResult.GetResult()

DoraALin avatar May 17 '17 03:05 DoraALin

@DoraALin Could you please compare the detail benchmark before and after this changes. (both for benchmark test and the real server test.)

absolute8511 avatar May 22 '17 11:05 absolute8511

@absolute8511 benchmark shows async rpc call does NOT fatser than replica synchronization. I will try with server test.

Sync RPC call 10000 211161 ns/op 0.61 MB/s --- BENCH: BenchmarkNsqdCoordPub1Replicator128-4 10000 279250 ns/op 0.46 MB/s --- BENCH: BenchmarkNsqdCoordPub2Replicator128-4 10000 297141 ns/op 0.43 MB/s --- BENCH: BenchmarkNsqdCoordPub3Replicator128-4 5000 251618 ns/op 4.07 MB/s --- BENCH: BenchmarkNsqdCoordPub1Replicator1024-4 10000 331672 ns/op 3.09 MB/s --- BENCH: BenchmarkNsqdCoordPub2Replicator1024-4 5000 307006 ns/op 3.34 MB/s --- BENCH: BenchmarkNsqdCoordPub3Replicator1024-4 3000 380150 ns/op 0.34 MB/s --- BENCH: BenchmarkNsqdCoordPub5Replicator128-4 5000 427857 ns/op 2.39 MB/s --- BENCH: BenchmarkNsqdCoordPub5Replicator1024-4 5000 325689 ns/op 0.39 MB/s --- BENCH: BenchmarkNsqdCoordPub4Replicator128-4 5000 344935 ns/op 2.97 MB/s --- BENCH: BenchmarkNsqdCoordPub4Replicator1024-4

Async RPC call PASS 10000 223244 ns/op 0.57 MB/s --- BENCH: BenchmarkNsqdCoordPub1Replicator128-4 5000 344346 ns/op 0.37 MB/s --- BENCH: BenchmarkNsqdCoordPub2Replicator128-4 5000 350341 ns/op 0.37 MB/s --- BENCH: BenchmarkNsqdCoordPub3Replicator128-4 5000 205962 ns/op 4.97 MB/s --- BENCH: BenchmarkNsqdCoordPub1Replicator1024-4 5000 322390 ns/op 3.18 MB/s --- BENCH: BenchmarkNsqdCoordPub2Replicator1024-4 5000 457972 ns/op 2.24 MB/s --- BENCH: BenchmarkNsqdCoordPub3Replicator1024-4 3000 441307 ns/op 0.29 MB/s --- BENCH: BenchmarkNsqdCoordPub5Replicator128-4 3000 392285 ns/op 2.61 MB/s --- BENCH: BenchmarkNsqdCoordPub5Replicator1024-4 5000 361425 ns/op 0.35 MB/s --- BENCH: BenchmarkNsqdCoordPub4Replicator128-4 3000 377754 ns/op 2.71 MB/s --- BENCH: BenchmarkNsqdCoordPub4Replicator1024-4

DoraALin avatar May 31 '17 03:05 DoraALin