DoctrineEncryptBundle icon indicating copy to clipboard operation
DoctrineEncryptBundle copied to clipboard

Published 20 hours ago • verified publisher icon absolute-quantum

Add missing return value for Command's execute() methods (Symfony >= 4.4)

Open sebb opened this issue 4 years ago • 2 comments

Fixes:

Return value of "Ambta\DoctrineEncryptBundle\Command\DoctrineEncryptStatusCommand::execute()" must be of the type int, "null" returned. when using Symfony 5

Similar to https://github.com/GiveMeAllYourCats/DoctrineEncryptBundle/pull/41 with the reviewers' suggestions implemented.

sebb avatar Jan 23 '21 20:01 sebb

It would probably be better not to use self::FAILURE and self::SUCCESS but rather 1 and 0 in order to still support versions of Symonfy < 5.1

tikoflano avatar May 28 '21 01:05 tikoflano

Similar to another pull request that that were copied: https://github.com/DoctrineEncryptBundle/DoctrineEncryptBundle/pull/4

Please see these comments:

  • https://github.com/absolute-quantum/DoctrineEncryptBundle/pull/65#issuecomment-1476301156
  • https://github.com/absolute-quantum/DoctrineEncryptBundle/pull/65#issuecomment-1638006829

The new package that I hope will be maintained by more than 1 person

r3hp1c avatar Jul 17 '23 13:07 r3hp1c