DoctrineEncryptBundle icon indicating copy to clipboard operation
DoctrineEncryptBundle copied to clipboard

Prevent update when nothing change on Entities with class inheritance

Open sh41 opened this issue 5 years ago • 1 comments

Related to #25, #28 & #35.

The implementation didn't handle Entities using class inheritance correctly as the Unit Of Work Identity Map entity name will refer to the root class of an Entity which uses inheritance but the cached decryptions array did not use the same reference.

This change adds tests for the scenario and provides a fix.

It also re-enables tests that were accidentally disabled by renaming the functional test cases from *Test.php to *TestCase.php in #36 which meant they were not picked up by the filter in phpunit.xml.dist.

sh41 avatar Aug 02 '20 15:08 sh41

Seems like this change is already part of: https://github.com/DoctrineEncryptBundle/DoctrineEncryptBundle

Please see these comments:

  • https://github.com/absolute-quantum/DoctrineEncryptBundle/pull/65#issuecomment-1476301156
  • https://github.com/absolute-quantum/DoctrineEncryptBundle/pull/65#issuecomment-1638006829

The new package that I hope will be maintained by more than 1 person

r3hp1c avatar Jul 17 '23 13:07 r3hp1c