magistrala icon indicating copy to clipboard operation
magistrala copied to clipboard

MF-888 - Add group, certs and bootstrap SDK tests

Open zzokki81 opened this issue 2 years ago • 3 comments

What does this do?

Added SDK tests

Which issue(s) does this PR fix/relate to?

Resolves #888

List any changes that modify/break current functionality

Have you included tests for your changes?

SDK Tests

Did you document any new/modified functionality?

No

Notes

zzokki81 avatar Jul 19 '22 13:07 zzokki81

Codecov Report

Merging #1629 (0d4f0f5) into master (78b025c) will increase coverage by 2.00%. The diff coverage is 82.35%.

@@            Coverage Diff             @@
##           master    #1629      +/-   ##
==========================================
+ Coverage   68.91%   70.91%   +2.00%     
==========================================
  Files         143      143              
  Lines       11544    11531      -13     
==========================================
+ Hits         7955     8177     +222     
+ Misses       2888     2578     -310     
- Partials      701      776      +75     
Impacted Files Coverage Δ
pkg/sdk/go/sdk.go 78.18% <ø> (ø)
pkg/sdk/go/certs.go 62.16% <81.25%> (+62.16%) :arrow_up:
pkg/sdk/go/bootstrap.go 58.92% <100.00%> (+58.92%) :arrow_up:
pkg/sdk/go/keys.go 56.86% <0.00%> (+56.86%) :arrow_up:
pkg/sdk/go/groups.go 60.46% <0.00%> (+60.46%) :arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov-commenter avatar Aug 12 '22 09:08 codecov-commenter

@zzokki81 Can you, please, resolve conflicts so we can review the PR?

dborovcanin avatar Feb 10 '23 07:02 dborovcanin

@zzokki81 Can you, please, resolve conflicts so we can review the PR? Sure, I'll take a look at that.

zzokki81 avatar Feb 14 '23 14:02 zzokki81