magistrala
magistrala copied to clipboard
MF1621 - Logical user removal
Signed-off-by: 0x6f736f646f [email protected]
What does this do?
Remove the user logically. I have added a new field called active so when we remove the user we set the value to be false. Listing users, you are also given the opportunity to list removed used or active users
Which issue(s) does this PR fix/relate to?
Resolves #1621
List any changes that modify/break current functionality
Have you included tests for your changes?
N/A
Did you document any new/modified functionality?
Not yet
Notes
N/A
Codecov Report
Merging #1620 (b02cc99) into master (e1992a6) will decrease coverage by
0.39%
. The diff coverage is35.40%
.
@@ Coverage Diff @@
## master #1620 +/- ##
==========================================
- Coverage 69.30% 68.91% -0.40%
==========================================
Files 138 138
Lines 11208 11344 +136
==========================================
+ Hits 7768 7818 +50
- Misses 2748 2830 +82
- Partials 692 696 +4
Impacted Files | Coverage Δ | |
---|---|---|
pkg/sdk/go/sdk.go | 78.18% <0.00%> (-2.96%) |
:arrow_down: |
pkg/sdk/go/users.go | 46.77% <0.00%> (-10.09%) |
:arrow_down: |
users/api/requests.go | 38.70% <0.00%> (-11.30%) |
:arrow_down: |
users/users.go | 79.48% <ø> (ø) |
|
users/api/endpoint.go | 45.57% <10.00%> (-8.59%) |
:arrow_down: |
users/postgres/users.go | 58.42% <40.00%> (-0.72%) |
:arrow_down: |
users/api/transport.go | 68.22% <53.33%> (-2.68%) |
:arrow_down: |
users/service.go | 65.25% <65.71%> (+1.96%) |
:arrow_up: |
users/postgres/init.go | 91.83% <100.00%> (+1.36%) |
:arrow_up: |
things/service.go | 66.07% <0.00%> (+0.71%) |
:arrow_up: |
... and 2 more |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
@drasko Can we merge this one?
@manuio I'll review
This must wait for @dborovcanin's approval
@drasko He had approved before my last remark