magistrala
magistrala copied to clipboard
MF-1584 Upgrade InfluxDB from 1.x to 2.x
Signed-off-by: fatih [email protected]
What does this do?
This upgrades the InfluxDB from Version 1.x to Version 2.x. This also updates writers and readers for InfluxDB upgrade.
Which issue(s) does this PR fix/relate to?
This resolves #1584
List any changes that modify/break current functionality
Have you included tests for your changes?
Did you document any new/modified functionality?
Notes
Codecov Report
Merging #1586 (1c54784) into master (931b48f) will increase coverage by
0.22%
. The diff coverage is93.38%
.
@@ Coverage Diff @@
## master #1586 +/- ##
==========================================
+ Coverage 69.18% 69.40% +0.22%
==========================================
Files 138 138
Lines 11231 11250 +19
==========================================
+ Hits 7770 7808 +38
+ Misses 2769 2758 -11
+ Partials 692 684 -8
Impacted Files | Coverage Δ | |
---|---|---|
readers/influxdb/messages.go | 83.13% <92.43%> (+6.11%) |
:arrow_up: |
consumers/writers/influxdb/consumer.go | 95.45% <100.00%> (+15.86%) |
:arrow_up: |
consumers/writers/influxdb/fields.go | 100.00% <0.00%> (+35.29%) |
:arrow_up: |
:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more
@fthdrmzzz @manuio when can this one be finished?
My Final Final exam is on 23rd of July. I predict that It will be finished before the end of the month
@fthdrmzzz Please check this: https://github.com/mainflux/mainflux/blob/e382e1b890e9ce73b3519f3b5b85b2424f9dd282/readers/influxdb/messages_test.go#L84
@fthdrmzzz @manuio Is this PR still active?
@dborovcanin Yes, it's ready to be reviewed
@fthdrmzzz Is this PR still active? If yes, can you, please, resolve conflicts and update PR so we can review?
@fthdrmzzz Is this PR still active? If yes, can you, please, resolve conflicts and update PR so we can review?
It is active and waiting for review. I resolved conversations by replying to them as @manuio suggested. Now, I resolved them manually.
If yes, can you, please, resolve conflicts and update PR so we can review?
Great to hear that. Please resolve conflicts and fix CI so we can review.
@fthdrmzzz Can you please resolve these conflicts?
Dear @manuio Can you assign someone else for two pull requests. A lot of time passed since my last review, I cannot continue due to my schedule.
Dear @manuio Can you assign someone else for two pull requests. A lot of time passed since my last review, I cannot continue due to my schedule.
@fthdrmzzz Sorry to hear that. @AryanGodara will take this one over.
Closing this one in favor of #1709. @fthdrmzzz We'll keep your contributions, thank you for your time and effort.