absinthe icon indicating copy to clipboard operation
absinthe copied to clipboard

Fix default_value error on enum type

Open haodt opened this issue 3 years ago • 7 comments

Hello, this PR aiming to fix the issue #1081 for the time being before we could come up with anything better.

Currently i'm trying to understand how notation and schema work so i tried my best at fixing the validation which is desirable for the time being since we are having troubles trying to upgrade our absinthe from 1.5.5 to 1.6.6. This issue caused everything to explode ( we indeed used alot of default value).

Any guidances would be appreciated!

haodt avatar Nov 15 '21 11:11 haodt

hey @benwilson512 any thoughts on this one?

haodt avatar Dec 17 '21 02:12 haodt

I just wanted to bump this as I stumbled upon the bug it solves today. The fix looks correct to me. I'd be happy to help if there's something more required to get this merged.

katafrakt avatar Feb 10 '23 10:02 katafrakt

Would love to see this merged in. 🙏

Helge801 avatar May 04 '23 22:05 Helge801

Bumping this as well. Tagging @benwilson512 again, this seems like a quick merge

sraka1 avatar May 23 '23 07:05 sraka1

Hey @benwilson512 Do you think we could go with this approach or suggest anything else? This issue blocked us from upgrading absinthe for a long time.

anvox avatar Sep 22 '23 14:09 anvox

We came to another workaround that removing default value from enum params. Default value is checked and filled by resolver. It's a bit more code but unblock upgrading.

anvox avatar Oct 25 '23 06:10 anvox

@benwilson512 please, review this PR!

HarshBalyan avatar Apr 23 '24 19:04 HarshBalyan