sqlalchemy-mixins icon indicating copy to clipboard operation
sqlalchemy-mixins copied to clipboard

Please add synonyms to the list of "settable_attributes"

Open sarapple opened this issue 3 years ago • 1 comments

Hi there- not sure if this project is still active,

The sqlalchemy Synonym column names are not contained in the list of settable_attributes.

https://docs.sqlalchemy.org/en/14/orm/mapped_attributes.html#synonyms

There is a check here for determining if the updated field is in the list of settable_attributes, and synonyms should be a settable field, per documentation on sqlalchemy.

https://github.com/absent1706/sqlalchemy-mixins/blob/f51e687286e01338f69944e6453aaa56b01fd00e/sqlalchemy_mixins/activerecord.py#L17

I unfortunately was not able to find where this field is set on the sqlalchemy orm side. If someone can point me to where it is, I would be happy to open a PR.

Thanks! Sara

sarapple avatar Mar 04 '21 23:03 sarapple

@sarapple Hey there, thanks for the reporting.

First of all, the project is active and will be supported, I've created an issue, where we collect all future requests from the community, please see #68

Regarding your suggestion, we will review it, and if it makes sense, we definitely will fix it.

myusko avatar Apr 15 '21 13:04 myusko