abseil-cpp icon indicating copy to clipboard operation
abseil-cpp copied to clipboard

Log address at which fault occurred in FailureSignalHandler.

Open satyamshekhar opened this issue 5 years ago • 3 comments

This PR changes the failure message to include fault address. Sample message after the change:

*** SIGBUS (0x270) received at time=1597958682 ***

Fault address provides useful information like whether the fault occurred on the heap or stack, if the SIGSEGV was nullptr, etc.

satyamshekhar avatar Aug 20 '20 21:08 satyamshekhar

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

googlebot avatar Aug 20 '20 21:08 googlebot

@googlebot I signed it!

satyamshekhar avatar Aug 20 '20 21:08 satyamshekhar

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

googlebot avatar Aug 20 '20 21:08 googlebot