abseil-cpp icon indicating copy to clipboard operation
abseil-cpp copied to clipboard

Fix CXX version build issue in Apple clang

Open infomaniac777 opened this issue 1 year ago • 3 comments

Fix CXX version build issue in Apple clang

On the latest Mac OS 15.1, the default C++ version is gnu++98 with the default Apple clang version 16.0.0 compiler. So the following does not complete successfully with Abseil requiring C++14 as minimum.

cmake -DABSL_BUILD_TESTING=ON -DABSL_USE_GOOGLETEST_HEAD=ON  ..
make -j 4

A check for C++14 being set at minimum is also added to the cmake file so the version failure is notified at an earlier stage when first running cmake.

infomaniac777 avatar Nov 05 '24 09:11 infomaniac777

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Nov 05 '24 09:11 google-cla[bot]

cmake -DABSL_BUILD_TESTING=ON -DABSL_USE_GOOGLETEST_HEAD=ON .. make -j 44

Dragonfly5596 avatar Dec 04 '24 03:12 Dragonfly5596

Hello @Dragonfly5596 , can you please clarify your comment ? Is it to build check with the PR included ?

infomaniac777 avatar Dec 04 '24 06:12 infomaniac777