abseil-cpp icon indicating copy to clipboard operation
abseil-cpp copied to clipboard

Try to fix #841

Open MBkkt opened this issue 3 years ago • 6 comments

As I see in #841 clang with undefined sanitizer with libstdc++ can't be fixed with additional compile/link option

MBkkt avatar Mar 23 '22 14:03 MBkkt

I don't think this change is desirable. If you want to use UBSAN, you have to link in the required libraries.

derekmauro avatar Mar 23 '22 20:03 derekmauro

I don't think libc++ required for clang ubsan. Without this patch clang with libstdc++ with ubsan is unusable, I think it's really annoying, and patch is simple, and don't affect others configuration

MBkkt avatar Mar 24 '22 09:03 MBkkt

@derekmauro Why I can't use abseil with clang ubsan with libstdc++?

I don't think this change is desirable.

I don't understand why

This option cannot be directly set, so I think if exist some valid configuration that doesn't work with this option we want to disable option for this configuration

MBkkt avatar Mar 28 '22 18:03 MBkkt

@derekmauro Can you answer?

MBkkt avatar Oct 06 '22 12:10 MBkkt

@derekmauro I still hope you will answer.

MBkkt avatar Oct 14 '22 19:10 MBkkt

Valery Mironov @.***> schrieb am Fr., 14. Okt. 2022, 9:44 PM:

@derekmauro https://github.com/derekmauro I still hope you will answer.

— Reply to this email directly, view it on GitHub https://github.com/abseil/abseil-cpp/pull/1144#issuecomment-1279391946, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOSHZHSY6FPI66M6TIJUF4TWDGZ2DANCNFSM5ROGBMPA . You are receiving this because you are subscribed to this thread.Message ID: @.***>

fsorry avatar Oct 14 '22 21:10 fsorry

GCC with libstdc++: bazel build --copt=-fsanitize=undefined --linkopt=-fsanitize=undefined --cxxopt=-std=c++14 ...

Clang with libstdc++: CC=clang bazel build --copt=-fsanitize=undefined --linkopt=-fsanitize=undefined --linkopt=-fsanitize-link-c++-runtime --cxxopt=-std=c++14 ...

derekmauro avatar Oct 26 '22 14:10 derekmauro

@derekmauro What is your version of gcc, clang, libstdc++?

MBkkt avatar Oct 26 '22 14:10 MBkkt

@derekmauro What is your version of gcc, clang, libstdc++?

MBkkt avatar Oct 31 '22 23:10 MBkkt

@derekmauro What is your version of gcc, clang, libstdc++?

If you are having a problem, you should be telling me how to reproduce it.

derekmauro avatar Nov 01 '22 00:11 derekmauro