abs icon indicating copy to clipboard operation
abs copied to clipboard

installer.sh did not detect Darwin

Open nicerobot opened this issue 6 years ago • 12 comments

installer.sh didn't detect Darwin properly and I was going to check it and maybe provide a PR but where is it?

nicerobot avatar Jan 09 '19 15:01 nicerobot

Oh jeez! It's in the docs folder :) sorry for the trouble!

odino avatar Jan 10 '19 18:01 odino

No worries. GitHub's search leaves a lot to be desired. It only found instance of the term "installer.sh" and not any files with that name. Or maybe i don't know how to interpret their results 😐 Thanks

nicerobot avatar Jan 10 '19 19:01 nicerobot

Try this trick: go to the home of the repo, type 't' and then you can search by filename ;-)

On Thu 10 Jan, 2019, 11:27 PM nicerobot <[email protected] wrote:

No worries. GitHub's search leaves a lot to be desired. It only found instance of the term "installer.sh" and not any files with that name. Or maybe i don't know how to interpret their results 😐 Thanks

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/abs-lang/abs/issues/105#issuecomment-453222371, or mute the thread https://github.com/notifications/unsubscribe-auth/AAUC5CbkmX8tHZL6rZ-TSd5j8XuaaDDJks5vB5QMgaJpZM4Z3xB8 .

odino avatar Jan 10 '19 20:01 odino

Thanks. I think I've learned that a few times before. Maybe someday it'll stick 😆

Oh, BTW, this issue was technically about OS detection. To properly install on macos requires updates to the script or invoking like

OSTYPE=darwin sh <(curl https://www.abs-lang.org/installer.sh) 

If i get some free time this weekend, I can provide an installer.sh enhancement PR (also needs to detect wget or curl too) though I don't currently have access to Windows so can't test those paths. Are you opposed to offering a separate installer.cmd?

nicerobot avatar Jan 10 '19 21:01 nicerobot

Oh, I thought mac's hasd the OSTYPE variable already set like linux:

~ ᐅ echo $OSTYPE
linux-gnu

Would super-appreciate a PR :)

odino avatar Jan 13 '19 08:01 odino

It's set but not to anything that's nicely usable. Mine is currently:

darwin18.0

nicerobot avatar Jan 13 '19 15:01 nicerobot

Ok, then I assume we should just look for the prefix Darwin in the ostype :)

On Sun 13 Jan, 2019, 7:16 PM nicerobot <[email protected] wrote:

It's set but not to anything that's nicely usable. Mine is currently:

darwin18.0

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/abs-lang/abs/issues/105#issuecomment-453837924, or mute the thread https://github.com/notifications/unsubscribe-auth/AAUC5DqtyymYQs9bQC0AFQn9i5Oxp-SVks5vC02-gaJpZM4Z3xB8 .

odino avatar Jan 13 '19 17:01 odino

OSTYPE=darwin sh <(curl https://www.abs-lang.org/installer.sh) % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 1439 100 1439 0 0 5031 0 --:--:-- --:--:-- --:--:-- 5031 Trying to detect the details of your architecture.

If these don't seem correct, head over to https://github.com/abs-lang/abs/releases and download the right binary for your architecture.

OS: darwin ARCH: 386

Are these correct? [y/N] y --2021-12-11 11:45:55-- https://github.com/abs-lang/abs/releases/latest/download/abs-darwin-386 Resolving github.com (github.com)... 140.82.121.4 Connecting to github.com (github.com)|140.82.121.4|:443... connected. HTTP request sent, awaiting response... 302 Found Location: https://github.com/abs-lang/abs/releases/download/2.5.1/abs-darwin-386 [following] --2021-12-11 11:45:55-- https://github.com/abs-lang/abs/releases/download/2.5.1/abs-darwin-386 Reusing existing connection to github.com:443. HTTP request sent, awaiting response... 404 Not Found 2021-12-11 11:45:56 ERROR 404: Not Found.

Still facing the error on my mac

% echo $OSTYPE darwin20.0

manishalankala avatar Dec 11 '21 10:12 manishalankala

@manishalankala are you working on a mac M1?

odino avatar Dec 12 '21 00:12 odino

More specifically, could you try to use this modified version of the installer and let me know whether it works? https://gist.github.com/odino/4795c7707964a25af2cb566493edd7ae

odino avatar Dec 12 '21 00:12 odino

@manishalankala are you working on a mac M1?

Yes it is

manishalankala avatar Dec 12 '21 21:12 manishalankala

More specifically, could you try to use this modified version of the installer and let me know whether it works? https://gist.github.com/odino/4795c7707964a25af2cb566493edd7ae

@odino Thanks it installed in the terminal

but i have a other problem , does this depends on jdk or need to do sym link to run jdk too env: abs: No such file or directory - current error while i have deploy.abs

manishalankala avatar Dec 12 '21 22:12 manishalankala