Andrew Brookins
Andrew Brookins
@seandstewart and @Andrew-Chen-Wang, you guys are the true heroes of aioredis. Apologies that I've not had the time I planned to work on this library after offering to help maintain...
@egnor Can you post example code that we can use to reproduce?
Interesting issue. I'm not able to reproduce with an SSL connection to a not-super-close Redis instance, myself, running your example code on Python 3.9.5. What version of Python do you...
@fedej Thank you for reporting! I'll look into this as soon as I can.
This does not appear to be straightforward. The Python docs claim ContextVars should only be created at the top level of a module, that is, outside of a class. Multiple...
@Andrew-Chen-Wang Have you looked into this much? I'm not sure how important this garbage collection reference in the docs is, or how different this is than the situation we already...
I wonder why we even need a ContextVar at all. 🤔 redis-py was trying to solve the problem that multiple threads could try to change the same Lock instance. We...
Right, it's a lock backed by a Redis key. I see in that thread that they did not actually resolve the question of whether the garbage collection problem mattered. It...
Oh, right, locks don't do the same thing. With thread-local storage, if two threads were using the same (Redis) Lock instance, one thread acquiring the Redis Lock would block the...
@Andrew-Chen-Wang I assume you already get pinged out the wazoo, but: I opened a PR with my changes to use ContextVar. See linked.