libkv icon indicating copy to clipboard operation
libkv copied to clipboard

Adding golang/dep

Open nmengin opened this issue 7 years ago • 6 comments

Adding the new tool golang/dep for the libkv project. This tool allows dependencies management.

Fix versions for dependencies as constraints or overrides when necessary.

nmengin avatar Sep 19 '17 15:09 nmengin

Coverage Status

Coverage remained the same at 84.124% when pulling 307f97f2d9077ecf8c06c5930a6d97073c5bd4f0 on nmengin:feature/add-go-dep into 0c1d2148a135219aa583425f6b2a943fbba52417 on abronan:master.

coveralls avatar Sep 19 '17 15:09 coveralls

Hi @nmengin, thank you for the PR!

I tried to avoid using any dependency management on the libkv side because I think it is better handled on the side of projects using the library (using dep/glide/godep/etc.). It is true that this is annoying because of occasional breakage of client libraries (for example recently with etcd/client and ugorji/go, although I submitted a change upstream in etcd to fix that).

I'm not against including this change but I'm not sure this is entirely necessary either (considering the small scale of the project).

Thoughts?

abronan avatar Sep 19 '17 17:09 abronan

Also it's broken on the CI somehow.

abronan avatar Sep 19 '17 17:09 abronan

Ok @abronan.

I just did it in the way to compile the master branch and submit you PR about ETCD management. I let you close this PR.

nmengin avatar Sep 19 '17 17:09 nmengin

Coverage Status

Coverage remained the same at 84.124% when pulling a90e52c60dcb4ac1050af8ce9478992857d2af4f on nmengin:feature/add-go-dep into 0c1d2148a135219aa583425f6b2a943fbba52417 on abronan:master.

coveralls avatar Sep 19 '17 17:09 coveralls

Coverage Status

Coverage remained the same at 84.124% when pulling 174070b8aa4c96b2d54c1a0ef9ccbaf76f404934 on nmengin:feature/add-go-dep into 0c1d2148a135219aa583425f6b2a943fbba52417 on abronan:master.

coveralls avatar Sep 20 '17 06:09 coveralls