libkv
libkv copied to clipboard
Adding golang/dep
Adding the new tool golang/dep for the libkv project. This tool allows dependencies management.
Fix versions for dependencies as constraints
or overrides
when necessary.
Coverage remained the same at 84.124% when pulling 307f97f2d9077ecf8c06c5930a6d97073c5bd4f0 on nmengin:feature/add-go-dep into 0c1d2148a135219aa583425f6b2a943fbba52417 on abronan:master.
Hi @nmengin, thank you for the PR!
I tried to avoid using any dependency management on the libkv side because I think it is better handled on the side of projects using the library (using dep/glide/godep/etc.). It is true that this is annoying because of occasional breakage of client libraries (for example recently with etcd/client
and ugorji/go
, although I submitted a change upstream in etcd to fix that).
I'm not against including this change but I'm not sure this is entirely necessary either (considering the small scale of the project).
Thoughts?
Also it's broken on the CI somehow.
Ok @abronan.
I just did it in the way to compile the master branch and submit you PR about ETCD management. I let you close this PR.
Coverage remained the same at 84.124% when pulling a90e52c60dcb4ac1050af8ce9478992857d2af4f on nmengin:feature/add-go-dep into 0c1d2148a135219aa583425f6b2a943fbba52417 on abronan:master.