Andre Brisco

Windows and MacOS targets are failing due to https://github.com/jmillikin/rules_bison/issues/15. I opted not to try to fix that in this change since I wasn't confident that I'd not impacted existing behavior....

@jmillikin despite the failed builds (see https://github.com/jmillikin/rules_bison/pull/14#issuecomment-2263768637) I think this is ready to review 🙏

For those waiting for this to land, a patch file can be downloaded here: [@rules_hdl//dependency_support/org_gnu_bison/bison_empty_glob.patch](https://github.com/hdl/bazel_rules_hdl/blob/acf12a967d84db546c6595fbf232b3406c3a15f4/dependency_support/org_gnu_bison/bison_empty_glob.patch)

> Thanks for the patch and bug report! > > > > This PR's commit log seems to have picked up some stray files from your working directory, so I...

I tried the following diff but ran into more issues downstream ```diff diff --git a/bison/rules/bison_cc_library.bzl b/bison/rules/bison_cc_library.bzl index bc662af..4038ce5 100644 --- a/bison/rules/bison_cc_library.bzl +++ b/bison/rules/bison_cc_library.bzl @@ -54,13 +54,14 @@ def _cc_library(ctx, bison_result):...

I wonder if this is caused by newer versions of rules_oci. What version are you using?

> @abrisco thanks for your reply. > > Yes, I'm using the newest (v2.0.0) rules_oci. Ah sorry, you'd mentioned the version in your original post 😅 It looks like the...

cc @Tpt let me know if I just misunderstood the initial implementation! I noticed the `pytests` don't have functions in them either but perhaps I missed that call out somewhere.

Thanks @Tpt! Easy fix! But I noticed now that the stubs don't seem to have any type info. Left is what I'd expect for the code, right is what was...

With https://github.com/PyO3/pyo3/pull/5025 closed how many more steps do you envision remain for full stubs to be generated?