HIDPowerDevice icon indicating copy to clipboard operation
HIDPowerDevice copied to clipboard

Remove begin/end methods to simplify the implementation

Open forderud opened this issue 1 year ago • 4 comments

Proposal to simplify the implementation by avoiding the need for manually calling begin() before using HIDPowerDevice_.

forderud avatar Sep 09 '24 09:09 forderud

conflict, needs to be resolved. Please note that HID.cpp is a core Arduino module

abratchik avatar Sep 16 '24 12:09 abratchik

conflict, needs to be resolved.

I've now rebased the PR to resolve the conflict.

Please note that HID.cpp is a core Arduino module

Does this mean that you want me to first submit a PR for updating the HID implementation in https://github.com/arduino/ArduinoCore-avr with the same change?

forderud avatar Sep 16 '24 13:09 forderud

I've proposed the same HID_ class changes to ArduinoCore-avr in https://github.com/arduino/ArduinoCore-avr/pull/570

forderud avatar Sep 16 '24 14:09 forderud

conflict, needs to be resolved.

I've now rebased the PR to resolve the conflict.

Please note that HID.cpp is a core Arduino module

Does this mean that you want me to first submit a PR for updating the HID implementation in https://github.com/arduino/ArduinoCore-avr with the same change?

Hi Fredrik, what I mean is - it makes no sense to refactor HID.cpp in this repo because this is a core Arduino module. I only took it here because there was no other option to override the implementation of the HID protocol in the official Arduino library. The intent was to make only necessary changes and ensure they are mergeable with the original. I saw you submitted a PR to ArduinoCore-avr, this is the right approach, I believe. The only problem is - Arduino core team is very conservative on accepting PRs, unfortunately.

abratchik avatar Sep 30 '24 09:09 abratchik