Add a SQLite implementation of the jeff.Storage interface

Open mtlynch opened this issue 3 years ago • 3 comments

Dec 09 '22 02:12 mtlynch

Thanks for the notes! I've been sick this week, so I'm a little behind, but I'll hopefully have time to follow up this weekend or next.

Dec 14 '22 13:12 mtlynch

In addition to the inline comments, could you also add a test to this file?

Sure, I added tests in 7d09c7a.

Perhaps also an example for the documentation?

I'm not seeing where this would go, as it doesn't look like the README has examples for any of the stores. Is there a place you have in mind?

Finally, do you think it's possible to use standard SQL as much as possible and make this work for any *sql.DB object passed in, or is that unrealistic?

I don't think this would be practical. MySQL/MSSQL/Postgres all have different semantics for prepared statements, so I don't think the syntax for SQLite would abstract away to the other DB types.

Dec 18 '22 22:12 mtlynch

@abraithwaite - Is this PR still under consideration?

May 07 '23 11:05 mtlynch