abp icon indicating copy to clipboard operation
abp copied to clipboard

Fix nullability in javascript proxy types in abp built-in modules

Open hillin opened this issue 10 months ago • 2 comments

Is there an existing issue for this?

  • [x] I have searched the existing issues

Is your feature request related to a problem? Please describe the problem.

Since we have rolled out https://github.com/abpframework/abp/pull/22120, all (well, most) user-generated proxies now have nullabilities correctly reflect their backend counterparts. However in abp's built-in modules, some types still have incorrect nullability. E.g. EntityDto<TKey> in the @abp/ng.core package:

export declare class EntityDto<TKey = string> {
    id?: TKey;   // should not be nullable
    constructor(initialValues?: Partial<EntityDto<TKey>>);
}

Describe the solution you'd like

Update these types with correct nullability.

Additional context

No response

hillin avatar Feb 14 '25 01:02 hillin

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Apr 26 '25 01:04 stale[bot]

I think this worths a bump...

hillin avatar Apr 28 '25 05:04 hillin

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Jun 27 '25 05:06 stale[bot]

I am closing this since it is duplicate of https://github.com/abpframework/abp/issues/22132

sumeyyeKurtulus avatar Jul 03 '25 06:07 sumeyyeKurtulus

@sumeyyeKurtulus They are not exactly the same issue, although it is reasonable to kill both birds with the same stone.

hillin avatar Jul 03 '25 06:07 hillin

That is why I closed it, we can refer to this on the other issue either.

sumeyyeKurtulus avatar Jul 03 '25 06:07 sumeyyeKurtulus