abp icon indicating copy to clipboard operation
abp copied to clipboard
verified publisher icon abpframework

Angular | Refactor modal component

Open Sinan997 opened this issue 1 year ago • 2 comments

Refactor modal component with the new signal API

Sinan997 avatar May 18 '24 13:05 Sinan997

Why we need this changes now ? Also is it ok with current usages ? our setted values are not the signal based type e.g: in identiy component modals

masum-ulu avatar May 19 '24 10:05 masum-ulu

Why we need this changes now ? Also is it ok with current usages ? our setted values are not the signal based type e.g: in identiy component modals

Provided value doesn't have to be signal, it can be signal or not. So, it is okey with the current usages. You can test it in your local by sinan/refactor-modal branch.

For more info about model inputs.

As far as i know we want to use new signal features of Angular. According to this idea i have refactor the modal component. If you think this isn't our goal, i can close the PR.

Sinan997 avatar May 19 '24 13:05 Sinan997