abp icon indicating copy to clipboard operation
abp copied to clipboard

Language status listener method in dynamic-layout needs to be refactor

Open mahmut-gundogdu opened this issue 1 year ago • 2 comments

related https://github.com/abpframework/abp/pull/18418

issue: https://github.com/abpframework/abp/blob/fa50d7e9702479d06ec90b5c5cce7bccb4ae3cb1/npm/ng-packs/packages/core/src/lib/components/dynamic-layout.component.ts#L108

mahmut-gundogdu avatar Dec 08 '23 13:12 mahmut-gundogdu

abpLocalize work with localization.instant. It should be observable

mahmut-gundogdu avatar Dec 08 '23 15:12 mahmut-gundogdu

after the implementation, I am not sure should wedo it . in the current version, translate pipes works as pure function and when the language changes, mount and unmound all components. Changing language is rare. So maybe we should keeep it as before. I am not sure. Due that. I didn't merged

mahmut-gundogdu avatar Jan 02 '24 05:01 mahmut-gundogdu

We can continue like this, listening the changes can be more costly

masum-ulu avatar Mar 18 '24 13:03 masum-ulu