ISettingValueProviderManager

Open muratyuceer opened this issue 3 years ago • 3 comments

Hello, SettingValueProviderManager look like ISingletonDependency but ISettingValueProvider implemented classes look like ITransientDependency Isn't there a design problem here?

Aug 28 '22 16:08 muratyuceer

We will check this design.

Aug 29 '22 03:08 maliming

Other modules are designed this way, I don't think this could cause any problems.

Sep 15 '22 06:09 maliming

Other modules are designed this way, I don't think this could cause any problems.

yes, it's fine as long as the creator of the custom settingvalue provider knows that it will work as a singleton, it's just misleading

Sep 15 '22 06:09 muratyuceer

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Nov 22 '22 19:11 stale[bot]