abp icon indicating copy to clipboard operation
abp copied to clipboard

Modifiers have an inconsistent declaration order

Open beriniwlew opened this issue 2 years ago • 3 comments

I'm seeing quite a few instances where the modifiers have an inconsistent declaration order.

For example:

public override async Task ProcessAsync(TagHelperContext context, TagHelperOutput output)

should be

public async override Task ProcessAsync(TagHelperContext context, TagHelperOutput output)

I've already made the modifications if you want me to create a PR for it.

beriniwlew avatar Aug 07 '22 14:08 beriniwlew

You can send PR if you have already done it. Thanks.

hikalkan avatar Aug 07 '22 14:08 hikalkan

Rider & Visual Studio have different defaults for that. We can configure StyleCop for that and prevent future conflicts.

enisn avatar Aug 09 '22 07:08 enisn

You can send PR if you have already done it. Thanks.

Not able to ATM. Will revisit later.

beriniwlew avatar Sep 07 '22 22:09 beriniwlew