Austin Bonander
Austin Bonander
I see what's going on. #3980 fixed the cancel-safety for `begin()` but `commit()` and `rollback()` are not cancel-safe: https://github.com/launchbadge/sqlx/blob/a802da0e674e3b890d2fa3580ee843d687f2e32f/sqlx-postgres/src/transaction.rs#L40 These should queue the command synchronously, decrement the depth, and _then_...
The intention has always been that if you want control over the generated structure, you should be using `query_as!()`. It's a little more boilerplate but it's going to be much...
> I'm not convinced by the claim that it's more maintainable. The more code there is, the more code there is to maintain, and the more duplication there is, the...
@wangxiaore888 this could use more information: * The logs you give don't match the `println!()` statements in the code. If you have modified the code from the original, please post...
@ZenasSong please run `cargo fmt`.
Likely similar to #3335
@sahbaazansari just go ahead and open a PR when you have something for me to look at.
There's kind of two orthogonal issues here: 1. `Pool::connect()` _et al_ should definitely return the connection error and not just eat it then _eventually_ return `PoolTimedOut`. That's a huge UX...
> i want to return to the user immediately that there was an internal error and not make him wait for 30s. You do know you can shorten the timeout,...
I would prefer to deprecate `async-std` for a release cycle before deleting it. Just cause it's discontinued doesn't mean people will stop using it immediately, especially because its constituent crates...