Austin Bonander
Austin Bonander
> I'll break up the size and do a component at a time for reviewers, will carry over feedback that's been received so far. Will close / migrate to draft...
@jayy-lmao I merged the `POINT` PR if you'd like to open another.
@jayy-lmao if I'm not mistaken, having merged #3773 means this is done now? I'm going to go ahead and close if that's the case.
This change appears innocuous enough, but I'm worried that people won't understand what this impl is for and will assume it does something different, i.e. make `.fetch_one()` return `None` instead...
(As for why to use autoderef specialization instead of just checking if the type is wrapped in `Option`: that can't see through type aliases.)
After some thought, I'm not entirely sure how much value this actually has. As I worked out in https://github.com/estuary/flow/issues/1676#issuecomment-2392077544, keepalive likely won't solve the original reporter's problem. It could be...
Yeah, you also can't dial a TCP connection from normal Webassembly which unfortunately makes this a non-starter. You'd have to compile for `wasm32-wasi` which is not a stable target IIRC...
@alu this appears related to the changes in #2652, can you advise.
@alu I think they're talking about the output of a `DESCRIBE` command for the table in question: https://dev.mysql.com/doc/refman/8.4/en/explain.html#explain-table-structure This might be the same issue as #3387
@eirnym that's a different issue entirely and is likely correct behavior. Please read about how data types and storage work in SQLite: https://www.sqlite.org/datatype3.html