Austin Bonander
Austin Bonander
I'm thinking we can change how much we log based on the log level set for `sqlx::query`: At `INFO`, we only print a short summary of the query as mentioned...
> With this model, would it ever be possible to `WARN` slow query with parameters in the log message? I didn't think of slow query logging when I wrote that...
True, but it could come in handy for reproducing slow queries. Instead of changing output for `DEBUG`/`WARN`, maybe we have a setter on `ConnectOptions`? ```rust /// Log query arguments (values...
Yeah, I think I tend to agree cause I personally don't really pay attention at all to the queries being logged, it just adds noise. And if you're running in,...
> But a more idiomatic approach is to implement `Executor` for `Stuff` and have execute take a `&mut Executor`. We did have that in earlier versions. The problem is implementing...
@demurgos it's been a while, do you have any interest in finishing this? We can earmark it for 0.7.0 so you can make breaking changes if necessary.
> But this got me curious and the [internal impl](https://github.com/launchbadge/sqlx/blob/326254fb51d4f8b5de7bf610af7a5f4b7ecbfa3b/sqlx-core/src/pool/connection.rs#L133) of PoolConnection makes use of the sqlx-rt crate to fetch a [statically stored common runtime](https://github.com/launchbadge/sqlx/blob/326254fb51d4f8b5de7bf610af7a5f4b7ecbfa3b/sqlx-rt/src/rt_tokio.rs#L20) for AsyncDrop purposes. No, it...
The original issue concerns async-std, not Tokio. The discussion as a whole has been muddied quite a bit because of that. Regarding Tokio, using a separate runtime to close the...
@jbis9051 yeah, you're deadlocking the `#[tokio::test]` runtime by doing that. The use of `pool` in the test function spawns a task to return the connection to the pool, which won't...