ace-window icon indicating copy to clipboard operation
ace-window copied to clipboard

Provide ace-window-posframe-mode

Open notmgsk opened this issue 4 years ago • 7 comments

Use posframes for overlays.

There does seem to be a slight but noticable delay when displaying the posframes. Haven't investigated too much into why.

notmgsk avatar Apr 04 '20 19:04 notmgsk

Thanks. Looks good. Do you have an Emacs Copyright Assignment? Both ace-window and posframe are on https://elpa.gnu.org/packages/.

abo-abo avatar Apr 28 '20 14:04 abo-abo

Working on it. Will let you know once it's done.

notmgsk avatar Apr 28 '20 14:04 notmgsk

Thanks in advance.

abo-abo avatar Apr 28 '20 15:04 abo-abo

I'm using this with (set-face-attribute 'aw-leading-char-face nil :weight 'bold :height 2.0) and the height scale in particular makes the labels stand out. I think it's probably too opinionated to set as a default, but perhaps it warrants inclusion in an example adjacent to the documentation for ace-window-posframe-mode in the eventual readme.

This is a useful patch for a great package! Thanks to you both.

obar avatar Jun 16 '20 19:06 obar

@abo-abo Finally I have the copyright assignment. I'm going to take a look at this again, and address the comments above.

notmgsk avatar Jan 23 '21 22:01 notmgsk

@notmgsk: The posframe display delay probably occurs because posframe creation takes a bit of time. You can mitigate the problem by caching and hiding posframes (and lazily creating them as needed, and/or pre-creating a bunch when Emacs idles).

gcv avatar Mar 02 '21 13:03 gcv

@notmgsk: The posframe display delay probably occurs because posframe creation takes a bit of time. You can mitigate the problem by caching and hiding posframes (and lazily creating them as needed, and/or pre-creating a bunch when Emacs idles).

Thanks. The lazy approach is already implemented, and has been sufficient for my usage.

notmgsk avatar Mar 02 '21 15:03 notmgsk

Hello! Thank you for ace-window! Is there a reason to not merge this PR?

josephmturner avatar Sep 01 '22 09:09 josephmturner

Merged. Thanks @notmgsk for the contribution. And to everyone who reviewed. And @josephmturner for the ping.

abo-abo avatar Sep 06 '22 18:09 abo-abo

@abo-abo @notmgsk Thank you!! This will make ace-window work much better with EXWM.

josephmturner avatar Sep 07 '22 00:09 josephmturner