spaces icon indicating copy to clipboard operation
spaces copied to clipboard
verified publisher icon ably

fix: stale connectionId

Open bastiankistner opened this issue 1 year ago • 1 comments

Instead of assigning the connectionId once in the space's constructor, it should be taken directly from the ably client. This ensures that the connectionId stays in sync even after a disconnect e.g. when the machine hibernates.

bastiankistner avatar Nov 01 '24 10:11 bastiankistner

Hi @bastiankistner ! Thank you for spotting the issue and opening a PR. It LGTM, and we're going to merge it once tests are passing (there is a sandbox issue right now preventing some tests to pass, not related to this PR)

VeskeR avatar Nov 08 '24 13:11 VeskeR