Library is currently incompatible with Salesforce Lightning Locker

[owenpearson]

Currently when using ably-js with Salesforce Lightning Locker the library throws the following error on import: Error: Cannot read properties of undefined (reading 'navigator')

The root cause is that the global object comes out undefined which is caused by the following logic automatically added by webpack:

var g;

// This works in non-strict mode
g = (function() {
	return this;
})();

try {
	// This works if eval is allowed (see CSP)
	g = g || new Function("return this")();
} catch (e) {
	// This works if the window reference is available
	if (typeof window === "object") g = window;
}

In lightning locker the function constructor invocation doesn't error here and just returns undefined, so the catch statement is never executed.

It looks like this logic no longer exists in webpack v5 so it is possible that upgrading webpack will resolve this. I've also created https://github.com/ably/ably-js/pull/993 which fixes compatibility with lightning locker without upgrading webpack, although it's an inelegant solution and I still need to test how this affects support for other platforms.

The simplest workaround currently is to just open the ably.js bundle and replace

g = (function() {
	return this;
})();

with

g = window;

Although bear in mind that this will only work for the unminified distribution of ably-js.

┆Issue is synchronized with this Jira Task by Unito