fix: handle iOS exceptions when requesting notification permission

[ttypic]

iOS forbids to ask for permissions in the async task

Summary by CodeRabbit

• Bug Fixes
  • Requests notification permission only when needed, reducing redundant prompts.
  • Handles platform-specific exceptions gracefully to prevent crashes during permission requests.
  • Provides clearer error feedback when permission is denied or the request fails.
  • Maintains existing push subscription behavior after permission handling.

[coderabbitai[bot]]

Walkthrough

Adjusted browser push permission handling: read Notification.permission, request only when 'default', wrap requestPermission in try/catch to handle platform exceptions, emit specific failure events on errors or denial, and keep subsequent push subscription logic unchanged.

Changes

Cohort / File(s)	Summary of Changes
Push permission flow handling src/plugins/push/getW3CDeviceDetails.ts	Checks Notification.permission first; calls requestPermission() only if 'default'. Wraps call in try/catch to handle platform (iOS) exceptions. Emits GettingPushDeviceDetailsFailed with ErrorInfo(…400, 40000) on exception; emits failure if permission not 'granted'. Push subscription logic unchanged.

Sequence Diagram(s)

sequenceDiagram
  participant U as Caller
  participant G as getW3CDeviceDetails
  participant N as Notification API
  participant P as Push API
  participant E as EventEmitter

  U->>G: invoke
  G->>N: read Notification.permission
  alt permission == "default"
    G->>N: requestPermission()
    note over N,G: Some platforms (e.g., iOS) may throw
    alt success
      N-->>G: permission result
    else throws
      G-->>E: emit GettingPushDeviceDetailsFailed(ErrorInfo("Failed to request permission...", 400, 40000))
      G-->>U: return
    end
  end

  alt permission != "granted"
    G-->>E: emit GettingPushDeviceDetailsFailed("User denied permission to send notifications")
    G-->>U: return
  else permission == "granted"
    G->>P: proceed with push subscription (unchanged)
    P-->>G: subscription details
    G-->>U: return subscription details
  end

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

A whisk of ears, a tap-tap key,
I checked the bell before I plea.
If iOS sneezes—catch and care,
Emit the truth into the air.
When granted, hop to push with glee—
Denied? I nibble logs, bug-free. 🐰🔔

[!TIP]

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.

✨ Finishing Touches

• [ ] 📝 Generate Docstrings

🧪 Generate unit tests

• [ ] Create PR with unit tests
• [ ] Post copyable unit tests in a comment
• [ ] Commit unit tests in branch fix/web-push-ios

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

• Visit our Status Page to check the current availability of CodeRabbit.
• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.