ably-java

ably-java copied to clipboard

Split integration tests

1

After looking at how to improve large integrated tests which will fail at some time for flaky tests we thought about separating realtime and rest tests in CI. The current...

qsdigor

Publishing to the local maven repository does not work

1

A big improvement of version 2.0 is the fact that you do not need to build JAR/AAR manually and include it in other projects to test the app, but instead,...

KacperKluka

EventEmitter.on() does not permit the same listener to be added multiple times

2

https://github.com/ably/ably-java/blob/9786de65bd44c2f139a53ee235535cb7617cbc87/lib/src/main/java/io/ably/lib/util/EventEmitter.java#L41 The two implementations of EventEmitter.on() prevents the same listener from being registered multiple times (and thus being invoked multiple times per event). It should allow this to happen as...

AndyTWF

Share test app set up & encoding fixture data

1

See https://github.com/ably/ably-js/issues/34, https://github.com/ably/ably-ruby/commit/a0b908113d7a8fadc43e3cacb235edb8a7d126cd and https://github.com/ably/ably-ruby/commit/bce255f6f36a99b2f4a735e3d80808f99036102e. We should share the test app set up and encoding / decoding fixture JSON between all client libraries to encourage consistency. ┆Issue is synchronized with...

mattheworiordan

Race condition with quick connections and disconnections

1

In a situation where the library reaches the `connected` state and the transport almost immediately fails, it can lead to a race condition whereby the connection state is permanently in...

AndyTWF

Quick calls to connect() results in thread leaks

1

Discovered inadvertently during the investigation of https://github.com/ably/ably-java/issues/917. If you use the autoconnect option in `ClientOptions` and also call `connect` on the ably instance, a race condition exists whereby threads are...

AndyTWF

- Fixed #871 - Related to #867

sacOO7

Public Final Properties Make It Hard To Test

3

I'm trying to write a test to ensure that my code is using the Ably SDK correctly however the public final channels property is final and there is no accessor...

benwaine

More verbose failure messages

2

See log below for connection failures, we should try and include the reason. I/System.out: (INFO): TokenAuth.authorise(): requesting new token 09-29 19:02:34.179 16436-16517/com.rundosrun.groupchat I/System.out: (INFO): Auth.requestToken(): using token auth with client-side...

mattheworiordan

sacOO7