ably-java
ably-java copied to clipboard
Enable and fix tests in RealtimeCryptoTest, RealtimeResumeTest and others
There are 44 tests that are still ignored in RealtimeCryptoTest RealtimeResumeTest and other classes. This is way too many and ignoring tests leaves parts of code untested. As the first step, we should enable all ignored tests in this class. If there are failing tests we need to fix them and add new ones if necessary.
➤ Automation for Jira commented:
The link to the corresponding Jira issue is https://ably.atlassian.net/browse/SDK-3108
Almost all tests are enabled and fixed. The ones that are not passing are:
- Tests in RestProxyTest, it looks like neither combination for setting manual ProxyOptions works.
- Test
auth_client_match_token_clientId_fail()
in RealtimeAuthTest passes locally but occasionally fails in CI/CD, for some reason expected failure code is 40100 rather than 40101 which is expected. - Test
realtime_presence_suspended_reenter()
in RealtimePresenceTest is flaky and fails on the second protocol iteration.
A lot of tests were improved to decrease the flakiness of tests. This is something that cannot be resolved this way and needs full refactoring to do so.
Created a PR to fix this issue => https://github.com/ably/ably-java/pull/991
Program client initiated sync same as https://github.com/ably/ably-cocoa/commit/93716bbe5815f8eec28abfe6ea89172270c5d474 for testing purpose.