ably-java icon indicating copy to clipboard operation
ably-java copied to clipboard

Push registration token refresh forces default ClientOptions

Open tcard opened this issue 5 years ago • 2 comments

Originally, you had to pass a AblyRest instance when refreshing registration tokens, but now, the AblyRest is instanced by us, using the deviceIdentityToken as key, with default options. So, if the client relies on non-default options (custom fallbacks, custom push registration), token refresh won't work.

┆Issue is synchronized with this Jira Task by Unito

tcard avatar Feb 26 '20 13:02 tcard

@paddybyers WDYT?

tcard avatar Feb 26 '20 13:02 tcard

I agree this is a problem - I thought I'd already raised an issue for it somewhere.

Edit: I can't find it. The environment definitely needs to be persisted as part of the persisted LocalDevice details, together with anything else that is going to be needed if there's going to be a registration token update authenticated by deviceIdentityToken.

paddybyers avatar Feb 26 '20 14:02 paddybyers