chore: rearrange code before refactoring

[ttypic]

It's hard to analyze the code when it is not arranged properly based on Java guidelines

Summary by CodeRabbit

• New Features

  • Enhanced error handling for proxy configuration in HTTP connections.
  • Improved clarity in WebSocket connection handling and close operations.

• Bug Fixes

  • Refined error handling for server responses, including authentication headers.

• Refactor

  • Code organization and readability improvements in both HTTP and WebSocket handling.
  • Method renaming and restructuring for better clarity and functionality.
  • Updated Gradle and wrapper scripts for improved build process efficiency.

[coderabbitai[bot]]

Walkthrough

The changes involve modifications to the HttpCore and WebSocketTransport classes within the Ably library. Enhancements include improved error handling, code readability, and structural clarity. Key method signatures have been updated, and new methods introduced to better manage preferred hosts. The organization of import statements and consistent formatting practices have been applied to the WebSocketTransport class, focusing on clarity without altering functionality. Additionally, updates have been made to the Gradle build configuration and wrapper scripts.

Changes

File Path	Change Summary
lib/src/main/java/io/ably/lib/http/HttpCore.java	- Improved error handling in proxy configuration and response handling. - Renamed setPreferredHost to getPreferredHost and added a new setPreferredHost method. - Refined static initialization and control flow formatting.
lib/src/main/java/io/ably/lib/transport/WebSocketTransport.java	- Reorganized imports and added constants for close codes. - Reformatted methods for consistency and clarity in error handling. - Updated inner class WsClient for better activity tracking.
android/build.gradle	- Updated Android Gradle plugin version from 4.1.0 to 4.2.2.
gradle/wrapper/gradle-wrapper.properties	- Updated Gradle version from 6.6.1 to 6.7.1.
gradlew	- Added copyright notice and licensing information. - Updated JVM options and simplified command-line argument handling.
gradlew.bat	- Added copyright notice and resolved path simplifications. - Updated JVM options and streamlined command execution logic.

Sequence Diagram(s)

sequenceDiagram
    participant Client
    participant WebSocketTransport
    participant WsClient

    Client->>WebSocketTransport: connect()
    WebSocketTransport->>WsClient: initialize()
    WsClient->>WebSocketTransport: onActivityTimerExpiry()
    WebSocketTransport->>Client: connection established

🐇 "In the code where rabbits hop,
Changes made, they’ll never stop.
With clearer paths and errors tamed,
In the world of bytes, we’re unashamed!
So let’s celebrate, with joy we sing,
For every fix, a happy spring!" 🐇

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example: -- I pushed a fix in commit <commit_id>, please review it. -- Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples: -- @coderabbitai generate unit testing code for this file. -- @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: -- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase. -- @coderabbitai read src/utils.ts and generate unit testing code. -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format. -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[sacOO7]

Refactoring looks okay to me, few more suggestions

1. More doc comments can be added.
2. Need to rename short variable names, those look very confusing.
3. Replace System.out with standard logging, also add error log messages for empty exception handling blocks.

[ttypic]

@sacOO7 It's not refactoring :) it's just rearranging the code. The code order was wrong, I made it right, based on official Java specification. We have static initializers, then static fields, methods, public fields, private fields, constructor, then public methods, private methods. Everything else is out of the scope of this PR. I haven't change a single line of code