ably-flutter icon indicating copy to clipboard operation
ably-flutter copied to clipboard

enhance logging on android part of plugin to be production-ready

Open tiholic opened this issue 5 years ago • 2 comments

Convert all System.out.println to a production ready logging system, probably SLF4J as suggested by QuintinWillison in this thread: https://github.com/ably/ably-flutter/pull/21#discussion_r462134457

┆Issue is synchronized with this Jira Task by Unito

tiholic avatar Jul 30 '20 06:07 tiholic

Searched the whole plugin for "System.out.*" and only one result appeared System.out.printf("%splatform method not implemented. %n", methodName); In other places it's standard Android logging Log.x. So I will assume that this is still relevant and we want to adopt a standardised logging system we do (maybe we already did) in Kotlin/Java libraries

ikbalkaya avatar Jan 04 '22 17:01 ikbalkaya

Relates to https://github.com/ably/ably-java/issues/64 - though, really, the crux of that is whether we should be adopting SLF4J (LOG4J is just an implementation... vulnerable to flaws, like any other implementation).

QuintinWillison avatar Jan 17 '22 11:01 QuintinWillison