ably-flutter icon indicating copy to clipboard operation
ably-flutter copied to clipboard

Improvise logging for Channel connection timeout on platform code

Open tiholic opened this issue 5 years ago • 3 comments
trafficstars

Why?

I've been calling Realtime#channels#get#attach without calling Realtime#connect first This iteratively tries to attach to the channel and on timeout, RealtimeChannelStatus will be set as suspended. I wasn't sure until paddybyers asked me whether I connected to the realtime instance in the first place!

Suggestion

Improvise VERBOSE/INFO logging on timeout and if realtime instance status is not connected to show:

attach timeout, realtime instance is not connected
retrying attach

NOTE: This enhancement must be done on platform code ably-java and ably-cocoa

┆Issue is synchronized with this Jira Task by Unito

tiholic avatar Jul 21 '20 13:07 tiholic

This suggestion is one possible solution. There may be others (e.g. fail faster).

See internal conversation.

QuintinWillison avatar Jul 21 '20 13:07 QuintinWillison

Hmm. I just went through conversation and there doesn't seem to be a decision on how to tackle this. Considering this is an issue rooting from the platform implementations I would say they should be handled there. WDYT @QuintinWillison ? If so I can create issues for corresponding platforms

ikbalkaya avatar Jan 04 '22 17:01 ikbalkaya

@ikbalkaya yes, please create platform issues and link them back to this issue. This issue should remain open until those dependencies have been updated here.

QuintinWillison avatar Jan 17 '22 11:01 QuintinWillison