ably-cocoa icon indicating copy to clipboard operation
ably-cocoa copied to clipboard

Add the rest of swift concurrency annotations

Open maratal opened this issue 1 year ago • 3 comments

Continuation of https://github.com/ably/ably-cocoa/issues/1962

Some types were not added because it's not obvious what should be added from the glance. I suggest to keep this issue open and add types that causing compilation errors in this description (meanwhile adding them to Ably+Dependencies.swift to add them all at once later in ably-cocoa):

ARTRealtimePresenceQuery

┆Issue is synchronized with this Jira Task by Unito

maratal avatar Sep 08 '24 12:09 maratal

If there are still types that we know need to be added, we should do this before doing a release.

lawrence-forooghian avatar Sep 10 '24 21:09 lawrence-forooghian

If there are still types that we know need to be added, we should do this before doing a release.

https://github.com/ably/ably-cocoa/pull/1973

maratal avatar Sep 12 '24 17:09 maratal

@umair-ably couldn't you post here screenshots of the warnings/errors with ARTRealtimeChannelOptions and ARTChannelProperties you've mentioned in this PR? I've also faced an error with the properties member in final class Channel: RealtimeChannelProtocol, but declaring it as a readonly getter solved the problem.

maratal avatar Sep 26 '24 21:09 maratal