ably-cocoa icon indicating copy to clipboard operation
ably-cocoa copied to clipboard

Published 20 hours ago • verified publisher icon ably

Check whether `ARTChannelStateChangeMetadata`’s `state:errorInfo:` initializer should set `storeErrorInfo` to `YES`

Open lawrence-forooghian opened this issue 2 years ago • 1 comments

From bdaa458c2286cea3ccc891418039d579bca489eb in #1596:

The convenience initializers of ARTChannelStateChangeMetadata are copied from those of ARTStatus, to be able to make minimal changes to existing code. I’m not convinced that the state:errorInfo: initializer should always be setting storeErrorInfo to YES (feels like in the nil errorInfo case it should behave the same as the state: initializer).

Investigate the emphasised part above.

┆Issue is synchronized with this Jira Task by Unito

lawrence-forooghian avatar Apr 02 '23 14:04 lawrence-forooghian

I think https://github.com/ably/ably-flutter/pull/283 covers a big part of this. (should cover everything except testing)

ikbalkaya avatar Jan 05 '22 12:01 ikbalkaya

➤ Igor Kurek commented:

Blocked for the same reason as https://ably.atlassian.net/browse/SDK-1385 ( https://ably.atlassian.net/browse/SDK-1385|smart-link )

ably-sync-bot avatar Feb 09 '22 13:02 ably-sync-bot

Time functions were implemented in https://github.com/ably/ably-flutter/pull/310, but stats are still waiting for ably-cocoa fix: https://github.com/ably/ably-flutter/pull/324

ikurek avatar Feb 25 '22 14:02 ikurek

blocked untill https://github.com/ably/ably-java/issues/733 and https://github.com/ably/ably-cocoa/issues/1284 are resolved

jamienewcomb avatar Apr 04 '22 10:04 jamienewcomb