ably-cocoa icon indicating copy to clipboard operation
ably-cocoa copied to clipboard

Document our reliance on the side effect

Open maratal opened this issue 3 years ago • 1 comments

I've put a few thoughts here. Also, when I first looked at this PR, I was confused about why the ARTSRWebSocket class, which also makes use of +[NSRunLoop ARTSR_networkRunLoop], hadn't been modified to wait for the run loop to become available. I think it's because ARTSRWebSocket makes use of the -[ARTSRProxyConnect openNetworkStreamWithCompletion:] method, which makes sure that the run loop is set up before it calls its completion handler. It would be good to document our reliance on this side effect.

Originally posted by @lawrence-forooghian in https://github.com/ably/ably-cocoa/pull/1538#pullrequestreview-1197960432

┆Issue is synchronized with this Jira Task by Unito

maratal avatar Nov 30 '22 20:11 maratal

➤ Automation for Jira commented:

The link to the corresponding Jira issue is https://ably.atlassian.net/browse/SDK-3116

sync-by-unito[bot] avatar Nov 30 '22 20:11 sync-by-unito[bot]