ably-cocoa icon indicating copy to clipboard operation
ably-cocoa copied to clipboard

Fix/1268 push error field

Open maratal opened this issue 3 years ago • 5 comments

maratal avatar Jan 20 '22 17:01 maratal

Perhaps before we start trying to parse this field, we should get it added to the documentation for the "get details from a registered device" etc REST API endpoints?

Isn't described in Common API behavior -> General? Just below the text All other standard HTTP statusCodes signify an error. Errors from all APIs are returned as an object of the form:

{
  error: {
    code: <ably error code>,
    message: <string>,
    statusCode: <http status code>
  }
}

🤔

lukasz-szyszkowski avatar Jan 21 '22 09:01 lukasz-szyszkowski

No, I think that’s describing what the response looks like if there’s an error in responding to the HTTP request. The error we’re talking about here is nested inside an object that represents a device, and I believe may be present even if the response has a 200 status.

lawrence-forooghian avatar Jan 21 '22 09:01 lawrence-forooghian

No, I think that’s describing what the response looks like if there’s an error in responding to the HTTP request. The error we’re talking about here is nested inside an object that represents a device, and I believe may be present even if the response has a 200 status.

agree 👍

lukasz-szyszkowski avatar Jan 21 '22 09:01 lukasz-szyszkowski

@maratal looks like this isn't ready for review and there's been no activity on it for a while, so I've converted it to a draft.

lawrence-forooghian avatar Mar 12 '22 07:03 lawrence-forooghian

Blocked by docs https://github.com/ably/specification/issues/23#issuecomment-1295033935

maratal avatar Oct 28 '22 13:10 maratal