spades icon indicating copy to clipboard operation
spades copied to clipboard

Support python 3.10

Open AlexGhiti opened this issue 3 years ago • 2 comments

distutils is deprecated and its use triggers DeprecationWarning which make some Ubuntu autopkgtests fail: fix this by replacing distutils by equivalent functions.

distutils.version is simply replaced with packaging.version.

distutils.copy_tree is a bit more complicated as preserve_mode/times does not exist directly in shutil.copytree function.

Signed-off-by: Alexandre Ghiti [email protected]

AlexGhiti avatar Feb 10 '22 16:02 AlexGhiti

@olga24912 Will you please check the fix?

asl avatar Feb 10 '22 16:02 asl

Hi @AlexGhiti !

Thank you for your PR and for your help in making SPAdes better!

The current patch might require some changes as SPAdes support multiple versions of Python(2.7, 3.6 - 3.10). I have already done some fixes in our developer repo, but I don't like how they look. Maybe you have some better solutions for the issues which I pointed out in the comments in this PR.

We will fix the issue with python 3.10 in the next release :)

Best regards, Olga

olga24912 avatar Mar 14 '22 18:03 olga24912

Obsolete

asl avatar Jul 10 '23 02:07 asl