ishell icon indicating copy to clipboard operation
ishell copied to clipboard

It's impossible to enter a literal tab (\t) in the shell

Open JelteF opened this issue 7 years ago • 3 comments

It seems shlex has quite weird behaviour for escaped characters. If you enter:

>>> command "a\tb"

The argument you get will be atb. Typing an actual literal tab character is ignored by the shell, so it's also not possible to enter a tab that way.

I don't see a very easy way to fix this, especially since shlex is not maintained anymore. Would you be okay with a PR that removes the dependency on shlex and uses strconv.Unquote() to handle escaping and quoting?

JelteF avatar Jan 23 '18 13:01 JelteF

It is more complex than simply unquoting. There are cases where you can have mixed quotes, special characters e.t.c. I considered handling the parsing but shlex has many edge cases handled already.

abiosoft avatar Jan 23 '18 14:01 abiosoft

Thanks for the explaination. I forked shlex to support Go escape sequences as well as it's regular escapes. I'm trying it out now on my own project and it seems to work great so far. I'm happy to make a pull request to ishell use the fork if you're open to that.

JelteF avatar Jan 24 '18 13:01 JelteF

Sure, I'm open to it. Thanks.

abiosoft avatar Jan 24 '18 15:01 abiosoft