caddy-exec icon indicating copy to clipboard operation
caddy-exec copied to clipboard

Fix processing of the args option

Open schlagert opened this issue 1 year ago • 2 comments

Merging the latest PR broke passing of arguments to commands. This PR will fix this issue. It also preserves the replacement placeholder values per request. Additionally, placeholders can now also be used in global commands.

The previous approach was prone to cause race conditions on heavily loaded proxies due to using shared memory for the replaced arguments which has also been addressed.

schlagert avatar Jun 20 '24 12:06 schlagert

Thanks a lot @schlagert, I was debugging this for a while. There really is a regression introduced in the last PR. Time for pinning my go modules.

PascaleBeier avatar Jun 29 '24 10:06 PascaleBeier

Is there anything we can do to get this PR approved/merged? I think the current state of master is pretty much broken.

schlagert avatar Aug 02 '24 06:08 schlagert

@abiosoft friendly ping

polarathene avatar Sep 14 '24 10:09 polarathene

Thanks @schlagert for the fix, and everyone else for your patience.

abiosoft avatar Sep 14 '24 12:09 abiosoft