react-input-trigger icon indicating copy to clipboard operation
react-input-trigger copied to clipboard

Published 20 hours ago • verified publisher icon abinavseelan

Layout compatibility using event.key

Open Razboi opened this issue 6 years ago • 4 comments

Using event.keyCode limits the keyboard layout compatibility. Added a trigger.key property for triggering with event.key

Razboi avatar Jul 16 '18 12:07 Razboi

Ops. Messed up building for my own project. It's reverted now

Razboi avatar Jul 16 '18 13:07 Razboi

To the maintainer, are there any plans to merge this feature? The library basically doesn't work on MAC for the character @

Teippo2020 avatar Jul 12 '19 20:07 Teippo2020

Apologises for not getting back to this earlier. 😞 Thank you so much for raising this fix @Razboi 🙂

Since this is a breaking change, can we assimilate this change into https://github.com/abinavseelan/react-input-trigger/tree/pre-release/2.0.0. This branch has some more breaking changes that fix non-standard input elements as highlighted in #10 and would be the next major version release for this package.

abinavseelan avatar Jul 14 '19 17:07 abinavseelan

That would be awesome! In the meantime (because I needed this feature so much) I created a fork and published it to npm, just in case anyone needs this feature before the release.

https://www.npmjs.com/package/react-input-trigger-fork

Teippo2020 avatar Jul 14 '19 21:07 Teippo2020