OEP-Frontend icon indicating copy to clipboard operation
OEP-Frontend copied to clipboard

Able to add candidates with invalid format of id and email ( Form Control )

Open sarthakmalik0810 opened this issue 4 years ago • 8 comments

Consider adding these checks. Also give suitable errors.

sarthakmalik0810 avatar May 14 '21 09:05 sarthakmalik0810

We already have a check in-place for if the fields are empty. @sarthakmalik0810 Can you elaborate on how you encountered this?

abhpd avatar May 17 '21 16:05 abhpd

@abhpd I believe there's no check for strings with spaces. Shall I add this check?

sarthakmalik0810 avatar May 17 '21 16:05 sarthakmalik0810

Also do you plan to add material-ui?

sarthakmalik0810 avatar May 17 '21 16:05 sarthakmalik0810

@abhpd I believe there's no check for strings with spaces. Shall I add this check?

Assigning it to you.

abhpd avatar May 18 '21 05:05 abhpd

Also do you plan to add material-ui?

I think implementing meterial-ui will need a redesign of the UI/UX. I think the better approach will be to Create a new completely responsive interface design with material-UI.

abhpd avatar May 18 '21 05:05 abhpd

@abhpd different institutes have different ids, so we cannot generally define what an invalid format for 'id' would be.

19BCS1114 avatar May 18 '21 11:05 19BCS1114

@abhpd different institutes have different ids, so we cannot generally define what an invalid format for 'id' would be.

It will be a simple check to confirm a non-spaced series or letter/numbers/special characters. I think this will cover most of the university ids

abhpd avatar May 18 '21 11:05 abhpd

#30 Partially solves the issue of empty or spaced string but still, we need a check for valid email and ID format

abhpd avatar May 19 '21 08:05 abhpd