Abhinav Kaushlya comments

Results 87 comments of


                                            Abhinav Kaushlya

Passing appropriate limit parameter for querying the users in the room

@nvzard This seems to be important since we already depend upon the member list. This seems to be more like a `needs design` issue.

Passing appropriate limit parameter for querying the users in the room

@nvzard Took help from the gitter guys, see [this](https://gitter.im/gitterHQ/gitter?at=5c867724293ac75db58ca2bb). But yeah the concept is same.

Passing appropriate limit parameter for querying the users in the room

Also I guess one more important thing would be, we should be able to store the list and update it as required since I think we shouldn't make calls for...

labhub.py: Alert when @mention is not in room

Obviously the tests will fail as I have removed the `is_room_member` function.

labhub.py: Alert when @mention is not in room

@jayvdb Can you please check the warning message so that I can make changes to the tests?

labhub.py: Alert when @mention is not in room

Blocked until https://github.com/errbotio/err-backend-gitter/issues/38 is solved.

Create CoroboTestCase that'll handle all the testing and mocking problem for good

We could have this, similar to the testing framework we have for the bears. Although this is quite different from that since this involves a lot of mocking and other...

Alert whenever a @mention is of someone not in the room

@jayvdb Please assign this to me 😃

Alert whenever a @mention is of someone not in the room

@jayvdb Has this been already taken care of? I found this: ``` if not self.is_room_member(invitee, msg): yield '@{} is not a member of this room.'.format(invitee) return ```

Alert whenever a @mention is of someone not in the room

@jayvdb So if I understand correctly if within any message if `@mention` is there and the person is not from the room then that should produce a warning message. I...