portfolio-js icon indicating copy to clipboard operation
portfolio-js copied to clipboard

gallery height 100%

Open kiul opened this issue 11 years ago • 5 comments

Hello Is there a way to do the height of the image covers the entire browser window I think the default height is 500px when i set auto and 100% it doesn't work, vertical and horizontal images are not on the same size (by the way, with the offsetLeft function, the vertical image are not very centered, but thanks you)

Merci

kiul avatar Oct 14 '13 09:10 kiul

hi!

I have written a small patch to address that. Comments are welcome.

guyzmo avatar Dec 10 '13 12:12 guyzmo

Hello I'm on vacation right now so I can't try without my laptop

Envoyé de mon iPhone

Le 10 déc. 2013 à 08:50, guyzmo [email protected] a écrit :

hi!

I have written a small patch to address that. Please, remind me to make a repository with that and a PR in time

— Reply to this email directly or view it on GitHub.

kiul avatar Dec 15 '13 10:12 kiul

Hi Guyzmo, I used your code for the 100% height and it works perfectly except when the screen size starts to get smaller. Anything below 700px roughly, the 100% height will fail to work and the whole horizontal slider will shrink like the pictures I attached. What is causing them to behave like that? Please help! Thanks!

shiqinwong avatar Feb 13 '15 08:02 shiqinwong

Hi @shiqinwong,

You attached no pictures ;-)

And I have no issue at around 700px in my usage.. Though I don't use an horizontal slider.

guyzmo avatar Feb 13 '15 09:02 guyzmo

Hi Guyzmo,

Somehow the pictures don't get attached. I managed to solve the issue by altering the codes at the resize function. Solved it, thanks alot for the response!

shiqinwong avatar Feb 14 '15 02:02 shiqinwong