GDSC-Lead-Map icon indicating copy to clipboard operation
GDSC-Lead-Map copied to clipboard

Published 20 hours ago • verified publisher icon abhinavsri360

UI Changes

Open srilaasya opened this issue 3 years ago • 8 comments

Standardize the social icons and change the style of the button Add footer

srilaasya avatar Apr 17 '21 03:04 srilaasya

Made UI changes via 79d65b1 Footer yet to be implemented.

abhinavsri360 avatar Apr 17 '21 06:04 abhinavsri360

In dark mode the contrast is bad. Cards remain white while the background turns dark. Maybe we can take inputs from https://material.io/design/color/dark-theme.html?

aravindvnair99 avatar Apr 17 '21 11:04 aravindvnair99

I too feel that the contrast is bad, moreover, I added a package through which the mode change is happening, will figure out some ways sometime soon. Sure, I will look after the resource, thanks for posting :)

abhinavsri360 avatar Apr 17 '21 13:04 abhinavsri360

@abhinavsri360 That package doesn't seem to be changing anything in the cards at present. Maybe if it goes to a lighter shade of grey, it should look fine

aravindvnair99 avatar Apr 17 '21 13:04 aravindvnair99

@aravindvnair99 Yeah, even I am planning to not use the package and code it right away.

abhinavsri360 avatar Apr 18 '21 02:04 abhinavsri360

I think the issue is resolved now via ed3c5c65e4ef731001b50e0e879eab163751908d wdyt? @srilaasya @aravindvnair99

abhinavsri360 avatar Apr 18 '21 11:04 abhinavsri360

@abhinavsri360 Looks better now. It doesn't automatically pick though based on OS setting. And doesn't persist through reload as well. Previously it did.

aravindvnair99 avatar Apr 18 '21 11:04 aravindvnair99

Cool, I'll set state using local storage for this.

abhinavsri360 avatar Apr 18 '21 13:04 abhinavsri360