Ignore issue if it is a Pull request
According to the Github API docs the Issues endpoint also returns Pull requests: https://developer.github.com/v3/issues/?q=is%3Aissue+is%3Aopen+sort%3Aupdated-desc#list-issues
This PR adds an extra filter that removes PR's from the list of Issues. More info can be found in the issue I made #72
Fixes #72
Codecov Report
Merging #73 into master will increase coverage by
0.03%. The diff coverage is100.00%.
@@ Coverage Diff @@
## master #73 +/- ##
==========================================
+ Coverage 86.70% 86.73% +0.03%
==========================================
Files 24 24
Lines 391 392 +1
Branches 80 80
==========================================
+ Hits 339 340 +1
Misses 47 47
Partials 5 5
| Impacted Files | Coverage Δ | |
|---|---|---|
| src/markdown/markdownIssues.js | 100.00% <100.00%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 410c60e...cb3af17. Read the comment docs.
Not sure if a test for this is needed. Let me know if I should add a test and how best add it (new test or adjust existing test).
@abhijeetps Can this PR get reviewed please?
@Glennmen , thank you. The PR looks good. I will test it in Weekly Digest Beta by the end of this month and I will let you know. I have been a little busy lately so, I couldn't come up to check the PR. 😄 I'm really sorry for the delay.
@abhijeetps No problem! Glad to see that there is stil some activity in this useful project. Let me know if you want me to change anything.
@abhijeetps Have you been able to test this PR yet?